OpenIndiana/ips
Watch
2
0
Fork
You've already forked ips
 0
Code Issues 29 Pull requests 2 Projects Releases 4 Packages Wiki Activity Actions

v1 CLI: remove false-success commands and guard publisher paths #48

Closed
forge wants to merge 0 commits from v1-cli-surface-20260923 into v1-integration-20260923
pull from: v1-cli-surface-20260923
merge into: OpenIndiana:v1-integration-20260923
Conversation 1 Commits - Files changed -
forge commented 2026-09-23 09:25:55 +00:00
First-time contributor
Copy link

The v1 depot package previously exposed commands that printed “not implemented” and exited successfully. This change removes those depot commands, makes unsupported pkg6 operations fail explicitly, and closes client false-success and publisher path-traversal deletion paths. The IPS package still ships only the depot and operator tools; pkg6 client is excluded from v1 binary artifacts in the release integration branch.

Validation: pkg6 23/23, pkg6depotd 109/109, libips image 10/10 and solver 17/17 focused tests; fmt clean. Independent Opus review found no server-package blockers. Existing multi-publisher pkg6 client catalog limitation remains tracked and is not shipped in the v1 package.

The v1 depot package previously exposed commands that printed “not implemented” and exited successfully. This change removes those depot commands, makes unsupported pkg6 operations fail explicitly, and closes client false-success and publisher path-traversal deletion paths. The IPS package still ships only the depot and operator tools; pkg6 client is excluded from v1 binary artifacts in the release integration branch. Validation: pkg6 23/23, pkg6depotd 109/109, libips image 10/10 and solver 17/17 focused tests; fmt clean. Independent Opus review found no server-package blockers. Existing multi-publisher pkg6 client catalog limitation remains tracked and is not shipped in the v1 package.
cli: reject unsupported depot and client operations
Some checks failed
CI / Linux (fmt / clippy / nextest / e2e / docs) (pull_request) Successful in 5m10s
Details
CI / illumos (OpenIndiana) build + nextest (pull_request) Failing after 5m22s
Details
2795a7c579
toasterson commented 2026-09-27 13:12:58 +00:00
Owner
Copy link

Superseded by #54, which brings the whole RC13 line (feat/historical-import, a strict superset of v1-integration-20260923) to main in one pull request, as decided in ADR-015 item 6. Nothing from this branch is lost; closing to keep one integration path.

Superseded by #54, which brings the whole RC13 line (`feat/historical-import`, a strict superset of `v1-integration-20260923`) to `main` in one pull request, as decided in ADR-015 item 6. Nothing from this branch is lost; closing to keep one integration path.
toasterson closed this pull request 2026-09-27 13:13:01 +00:00
Some checks failed
CI / Linux (fmt / clippy / nextest / e2e / docs) (pull_request) Successful in 5m10s
Details
CI / illumos (OpenIndiana) build + nextest (pull_request) Failing after 5m22s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Crazy Idea
Something that went through my mind which is not part of the core use case but fun

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority/Critical
The priority is critical

  
Priority/High
The priority is high

  
Priority/Low
The priority is low

  
Priority/Medium
The priority is medium

  
Reviewed/Confirmed
Issue has been confirmed

  
Reviewed/Duplicate
This issue or pull request already exists

  
Reviewed/Invalid
Invalid issue

  
Reviewed/Won't Fix
This issue won't be fixed

  
Status/Abandoned
Somebody has started to work on this but abandoned work

  
Status/Blocked
Something is blocking this issue or pull request

  
Status/Need More Info
Feedback is required to reproduce issue or to continue work

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
wayfinder:grilling
Wayfinder decision ticket: grilling

  
wayfinder:map
Wayfinder map issue (parent of decision tickets)

  
wayfinder:prototype
Wayfinder decision ticket: prototype

  
wayfinder:research
Wayfinder decision ticket: research

  
wayfinder:task
Wayfinder ticket: task that unblocks a decision

  
wontfix
Will not be actioned

No labels
Compat/Breaking
Crazy Idea
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Status/Abandoned
Status/Blocked
Status/Need More Info
needs-info
needs-triage
ready-for-agent
ready-for-human
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
OpenIndiana/ips!48
No description provided.