toasterson/Anima
Watch
0
0
Fork
You've already forked Anima
 0
Code Issues 1 Pull requests 86 Projects Releases Packages Wiki Activity Actions

Astra lanes stall: gpt-6-astra provider turn failures + central-admission retirement deadlock pin all four astra-impl executors #767

Open
toasterson wants to merge 3 commits from anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b into main
pull from: anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
merge into: toasterson:main
Conversation 0 Commits 3 Files changed 12 +774 -20
toasterson commented 2026-10-01 20:38:02 +00:00
Owner
Copy link

Centrally closed sessions can remain pinned behind bootstrap/result-delivery prerequisites. This change adopts authenticated, exact-session closure before those prerequisites, then uses the existing retirement path to enforce terminal turns, pending effects, workspace cleanup, audit, and exact-attempt ownership release. Registered Changes and publication history are preserved; no business, review, or CI gate is cleared.

The recovery also fixes a race where revocation was recorded before successful admission became known. Cleanup now follows the admitted owner while retaining the revocation record. Closure detection returns whether it actually adopted an intent, so a competing intent cannot cause a silent early-return loop. The retirement test fixture uses the current operator.write authorization.

Validation at 3df97510b3deeac576b79a80b9f3d8a9241c30ee:

  • Actual PostgreSQL 16 retirement regression passed with cargo test --locked -p anima-server --test central_session_retirement -- --ignored --test-threads=1. Its comprehensive test exercises concurrent replay, transactional rollback, pending effects, cleanup, preserved Changes and later attempts. The added admitted-revocation regression failed before the repair and passed afterward.
  • All five focused protocol/diagnostic tests passed with cargo test --locked -p anima-akh --test reconciliation.
  • Strict Clippy passed with cargo clippy --locked -p anima-server -p anima-akh --lib --test central_session_retirement --test reconciliation -- -D warnings.
  • git diff --check passed; current main da39c8749b6fbea43d6df9557b37aa0b2c248e76 is integrated.

Actual Fable (claude-fable-5-1) reviewed exact head 3df97510b3deeac576b79a80b9f3d8a9241c30ee and approved with no blocking issues on 2026-10-06. Review session: 9b15e366-8d9d-4068-bb06-d19d9815f235. This is external review evidence; Anima-native resync and gates remain pending while its service is unavailable.

These are local protocol/fixture checks. The original Astra provider failure cause and successful live turns on all four lanes remain unverified. Native exact-head review/CI gates, merge, and deployment remain separate requirements.

<!-- anima-work-item:01a0b5e6-562c-7203-aaf0-b083da81cd7b --> Centrally closed sessions can remain pinned behind bootstrap/result-delivery prerequisites. This change adopts authenticated, exact-session closure before those prerequisites, then uses the existing retirement path to enforce terminal turns, pending effects, workspace cleanup, audit, and exact-attempt ownership release. Registered Changes and publication history are preserved; no business, review, or CI gate is cleared. The recovery also fixes a race where revocation was recorded before successful admission became known. Cleanup now follows the admitted owner while retaining the revocation record. Closure detection returns whether it actually adopted an intent, so a competing intent cannot cause a silent early-return loop. The retirement test fixture uses the current `operator.write` authorization. Validation at `3df97510b3deeac576b79a80b9f3d8a9241c30ee`: - Actual PostgreSQL 16 retirement regression passed with `cargo test --locked -p anima-server --test central_session_retirement -- --ignored --test-threads=1`. Its comprehensive test exercises concurrent replay, transactional rollback, pending effects, cleanup, preserved Changes and later attempts. The added admitted-revocation regression failed before the repair and passed afterward. - All five focused protocol/diagnostic tests passed with `cargo test --locked -p anima-akh --test reconciliation`. - Strict Clippy passed with `cargo clippy --locked -p anima-server -p anima-akh --lib --test central_session_retirement --test reconciliation -- -D warnings`. - `git diff --check` passed; current main `da39c8749b6fbea43d6df9557b37aa0b2c248e76` is integrated. Actual Fable (`claude-fable-5-1`) reviewed exact head `3df97510b3deeac576b79a80b9f3d8a9241c30ee` and approved with no blocking issues on 2026-10-06. Review session: `9b15e366-8d9d-4068-bb06-d19d9815f235`. This is external review evidence; Anima-native resync and gates remain pending while its service is unavailable. These are local protocol/fixture checks. The original Astra provider failure cause and successful live turns on all four lanes remain unverified. Native exact-head review/CI gates, merge, and deployment remain separate requirements.
WI-870: retire centrally closed sessions and retain typed failures
All checks were successful
CI / conflict-check (push) Successful in 9m57s
Details
CI / test (push) Successful in 19m1s
Details
7e2955110b
fix: reconcile closed admitted sessions after revocation
All checks were successful
CI / conflict-check (push) Successful in 17m1s
Details
CI / test (push) Successful in 28m48s
Details
3df97510b3
fix(WI-870): retry CI log-drain timeouts as infrastructure failures
Some checks failed
CI / conflict-check (push) Failing after 13m53s
Details
CI / test (push) Failing after 17m41s
Details
72aa4835b7
Some checks failed
CI / conflict-check (push) Failing after 13m53s
Details
CI / test (push) Failing after 17m41s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b:anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git switch anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git switch anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git rebase main
git switch main
git merge --ff-only anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git switch anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git rebase main
git switch main
git merge --no-ff anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git switch main
git merge --squash anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git switch main
git merge --ff-only anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git switch main
git merge anima/01a0b5e6-562c-7203-aaf0-b083da81cd7b
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
toasterson/Anima!767
No description provided.