fix(review): use the canonical prompt for local workflow handbacks #771

Merged

toasterson merged 1 commit from codex/local-review-default-prompt-20261004 into main

2026-10-04 10:49:23 +00:00

toasterson commented

2026-10-04 10:26:51 +00:00

Owner

Local-workflow handbacks with a null pinned AI review prompt currently reach the scheduler but fail central admission with review phase requires a prompt template. Resolve only that local null case to the established WI-221 default, and retain the effective text in the existing dispatch prompt/hash path. Custom and explicit blank prompts, fleet configuration, immutable graph pins, handback fencing and current-head gates keep their existing behavior.

Validated at d9fbf12: four unit regressions, two real PostgreSQL workflow tests without skips, and strict Clippy for anima-db/anima-server (--no-deps; seven pre-existing warnings in the unchanged pinned Solstice common dependency are recorded separately). Independent Anima-rule source review passed. No database migration or shared deployment is included.

Unblocks RedDwarf WI6 01a0f6e0-ddae-7be2-a3a9-a8bad3246342 and its current-head review on PR8. Deployment, actual verdicts and canonical CI remain separate acceptance steps.

Local-workflow handbacks with a null pinned AI review prompt currently reach the scheduler but fail central admission with `review phase requires a prompt template`. Resolve only that local null case to the established WI-221 default, and retain the effective text in the existing dispatch prompt/hash path. Custom and explicit blank prompts, fleet configuration, immutable graph pins, handback fencing and current-head gates keep their existing behavior. Validated at d9fbf12: four unit regressions, two real PostgreSQL workflow tests without skips, and strict Clippy for anima-db/anima-server (`--no-deps`; seven pre-existing warnings in the unchanged pinned Solstice common dependency are recorded separately). Independent Anima-rule source review passed. No database migration or shared deployment is included. Unblocks RedDwarf WI6 `01a0f6e0-ddae-7be2-a3a9-a8bad3246342` and its current-head review on [PR8](https://code.aopc.cloud/CloudNebulaProject/reddwarf/pulls/8). Deployment, actual verdicts and canonical CI remain separate acceptance steps.

toasterson added 1 commit

2026-10-04 10:26:52 +00:00