Fix merged Q1/Q2/Q4 integration fixtures exposed by nightly

toasterson commented

2026-10-19 20:21:53 +00:00

Owner

The merged Q4 ACL correctly denies a foreign exact work item before project lookup, but the old integration fixture still expected two project IDs in the denial. Update that fixture to assert the exact denial and no project identifier disclosure. Q1 and Q2 also added direct WorkItemRepo::create calls in their provider-window and brief-budget test fixtures. Create and enter working through the canonical lifecycle service instead, binding the actual pinned graph phase and recording its audit history.

Attribution was run with exactly the seven failed nightly integration files on clean pre-series b4ab5f6acd and current main b083a89ad8. Forensics passes before the series and fails on main due to Q4 #799. The lifecycle guard already fails before the series on unchanged external_merge.rs; Q1 #795 and Q2 #796 add forbidden fixture calls in provider_cooldown.rs and scheduler.rs, which this patch removes. This PR does not change the pre-existing external_merge guard violation or the seven pre-existing operator.write fixture failures across five other test files.

Validation: both seven-file attribution runs completed locally with real Docker/PostgreSQL and no skips. Focused exact-head validation passed at 378d9e154a: cargo check -p anima-server --lib; forensics1; provider-window3 including the PostgreSQL single-flight/restart/backoff test; Q2 HTTP/four-lock/brief-refusal PostgreSQL1. The lifecycle guard is expected to continue reporting the separately documented external_merge baseline failure. No production authorization, scheduling or lifecycle policy changes.

The authoritative earlier full-series nightly at8f262bca passed57/64 pool jobs in each execution and failed these same7 files. The logs contain9 named failing tests. Local evidence: analysis-anima-3w/nightly-seven-attribution.md/.json; exact commands, UTC times and log hashes in attribution-pre-series.json and attribution-current-main.json.

Operator merge gate retained. No deployment or live recovery.

Current exact head: 378d9e154a1bce3c153f9c917e514de74a0fa39b. All focused checks above ran locally on clean pushed source with pristine pinned Solstice common, two Cargo jobs, debug/incremental disabled and31.25GiB disk stop floor. The lifecycle scanner still fails specifically on unchanged external_merge.rs, as it does on pre-series main; the expected baseline failure is checked separately and is not represented as a passing Rust test. Added Q1/Q2 fixture violations are gone. Exact receipt main-fixtures-exact.log.receipt.json; log SHA256 1f4057dbcbc651775c3d166feb1d8cf8f578b5fe8bbd8b1fc4d6e8ed24f6e2fe.

The earlier canonical fixture assertion used a legacy workflow_phases ID; normal follow-up a022fdeb corrected it to the lifecycle service's pinned graph phase. The subsequent guard exposed Q2's previously masked fixture call; normal follow-up378d9e15 removes it and passes the Q2 PostgreSQL regression. No force-push.

Recommended human order: this focused main fix, then #802 → #803 → #804. Those branches include this fix by ordinary dependency merges. Pre-existing baseline failures remain a separate follow-up and still prevent claiming a green full nightly.

Authoritative exact-head Solstice at20:45Z: Rust job d0376d97-c692-408c-9be0-6cdca3a75404 and conflict job 490c3259-6cde-47a8-9383-08a89f420900 both succeeded. Full SHA checkout, genuine completed categories,568 server unit tests and Clippy verified; Rust category ALL CHECKS PASSED and runner job complete. pr-805-solstice-verified.json retains every category hash. This is commit-mode CI; the separate local exact-head PostgreSQL receipts above remain the runtime regression proof. Human merge gate unchanged.

The merged Q4 ACL correctly denies a foreign exact work item before project lookup, but the old integration fixture still expected two project IDs in the denial. Update that fixture to assert the exact denial and no project identifier disclosure. Q1 and Q2 also added direct WorkItemRepo::create calls in their provider-window and brief-budget test fixtures. Create and enter working through the canonical lifecycle service instead, binding the actual pinned graph phase and recording its audit history. Attribution was run with exactly the seven failed nightly integration files on clean pre-series b4ab5f6acd745070804f1a03a8715dfb4b2a759a and current main b083a89ad8224c844a3db37e38167e21184aa163. Forensics passes before the series and fails on main due to Q4 #799. The lifecycle guard already fails before the series on unchanged external_merge.rs; Q1 #795 and Q2 #796 add forbidden fixture calls in provider_cooldown.rs and scheduler.rs, which this patch removes. This PR does not change the pre-existing external_merge guard violation or the seven pre-existing operator.write fixture failures across five other test files. Validation: both seven-file attribution runs completed locally with real Docker/PostgreSQL and no skips. Focused exact-head validation passed at 378d9e154a1bce3c153f9c917e514de74a0fa39b: cargo check -p anima-server --lib; forensics1; provider-window3 including the PostgreSQL single-flight/restart/backoff test; Q2 HTTP/four-lock/brief-refusal PostgreSQL1. The lifecycle guard is expected to continue reporting the separately documented external_merge baseline failure. No production authorization, scheduling or lifecycle policy changes. The authoritative earlier full-series nightly at8f262bca passed57/64 pool jobs in each execution and failed these same7 files. The logs contain9 named failing tests. Local evidence: analysis-anima-3w/nightly-seven-attribution.md/.json; exact commands, UTC times and log hashes in attribution-pre-series.json and attribution-current-main.json. Operator merge gate retained. No deployment or live recovery. Current exact head: `378d9e154a1bce3c153f9c917e514de74a0fa39b`. All focused checks above ran locally on clean pushed source with pristine pinned Solstice common, two Cargo jobs, debug/incremental disabled and31.25GiB disk stop floor. The lifecycle scanner still fails specifically on unchanged external_merge.rs, as it does on pre-series main; the expected baseline failure is checked separately and is not represented as a passing Rust test. Added Q1/Q2 fixture violations are gone. Exact receipt main-fixtures-exact.log.receipt.json; log SHA256 `1f4057dbcbc651775c3d166feb1d8cf8f578b5fe8bbd8b1fc4d6e8ed24f6e2fe`. The earlier canonical fixture assertion used a legacy workflow_phases ID; normal follow-up a022fdeb corrected it to the lifecycle service's pinned graph phase. The subsequent guard exposed Q2's previously masked fixture call; normal follow-up378d9e15 removes it and passes the Q2 PostgreSQL regression. No force-push. Recommended human order: this focused main fix, then #802 → #803 → #804. Those branches include this fix by ordinary dependency merges. Pre-existing baseline failures remain a separate follow-up and still prevent claiming a green full nightly. Authoritative exact-head Solstice at20:45Z: Rust job `d0376d97-c692-408c-9be0-6cdca3a75404` and conflict job `490c3259-6cde-47a8-9383-08a89f420900` both succeeded. Full SHA checkout, genuine completed categories,568 server unit tests and Clippy verified; Rust category ALL CHECKS PASSED and runner job complete. `pr-805-solstice-verified.json` retains every category hash. This is commit-mode CI; the separate local exact-head PostgreSQL receipts above remain the runtime regression proof. Human merge gate unchanged.

toasterson added 1 commit

2026-10-19 20:21:53 +00:00

Fix Q1 and Q4 integration fixtures after the merge train

CI / test (push) Has been cancelled

Details

CI / conflict-check (push) Has been cancelled

Details

7e39db1076

toasterson added 1 commit

2026-10-19 20:25:41 +00:00

Bind the limit fixture to the canonical graph phase instance

CI / conflict-check (push) Has been cancelled

Details

CI / test (push) Has been cancelled

Details

a022fdeb1d

toasterson added 1 commit

2026-10-19 20:28:42 +00:00

Use canonical lifecycle setup for the Q2 dispatch fixture too

CI / conflict-check (push) Successful in 39s

Details

CI / test (push) Successful in 10m12s

Details

378d9e154a

toasterson changed title from ~~Fix Q1/Q4 integration fixtures exposed by full-series nightly~~ to Fix merged Q1/Q2/Q4 integration fixtures exposed by nightly

2026-10-19 20:32:34 +00:00

toasterson referenced this pull request

2026-10-19 20:45:13 +00:00

S2: bound final MCP responses with private lossless artifact receipts #802

toasterson referenced this pull request

2026-10-19 20:45:19 +00:00

Persist canonical central model usage and terminal provenance #803

toasterson referenced this pull request

2026-10-19 20:45:23 +00:00

Run database integration pool for migration and test PRs #804

toasterson merged commit c2afbd43fa into main

2026-10-19 20:45:31 +00:00