fix(lilith): exam adapter args have no enable_thinking; read it tolerantly #563

Merged

toasterson merged 1 commit from fix/lilith-exam-enable-thinking into main 2026-10-06 20:12:18 +00:00

Conversation 1 Commits 1 Files changed 1 +3 -2

toasterson commented 2026-10-06 18:56:58 +00:00

Owner

Copy link

exam/run_acceptance.py builds the adapter arguments as a SimpleNamespace; PR #559 read args.enable_thinking unconditionally, and the run-4 acceptance crashed at the chat items after the candidate dojo arm (AttributeError: 'types.SimpleNamespace' object has no attribute 'enable_thinking'). getattr(args, "enable_thinking", None) keeps the server default for the exam, as in runs 1–3. Tests: dojo runner + exam suites green.

`exam/run_acceptance.py` builds the adapter arguments as a `SimpleNamespace`; PR #559 read `args.enable_thinking` unconditionally, and the run-4 acceptance crashed at the chat items after the candidate dojo arm (`AttributeError: 'types.SimpleNamespace' object has no attribute 'enable_thinking'`). `getattr(args, "enable_thinking", None)` keeps the server default for the exam, as in runs 1–3. Tests: dojo runner + exam suites green.

toasterson added 1 commit 2026-10-06 18:56:58 +00:00

fix(lilith): exam adapter args have no enable_thinking; read it tolerantly ... 1dc198f6a0

run_acceptance builds the adapter arguments as a plain namespace; PR #559 read args.enable_thinking unconditionally and the run-4 acceptance crashed at the chat items after the candidate dojo arm. getattr with None keeps the server default there.

toasterson commented 2026-10-06 20:12:14 +00:00

Author

Owner

Copy link

Merging with CI / test-akh-medu red: that job is cargo test (Rust) and failed after 26 min on run 4041 job 4; this PR changes two Python lines in scripts/lilith/dojo/baseline.py and no Rust file. The same job passed on the previous main head (4d45b65c, PR #559). Local evidence: uv run --no-project --with pytest python -m pytest dojo/tests program/tests exam -q → 729 passed, 4 skipped. Reason for not waiting on a rerun: the run-4 acceptance resume is blocked on this fix and the pod is stopped to avoid idle spend (operator instruction 2026-10-06).

Merging with `CI / test-akh-medu` red: that job is `cargo test` (Rust) and failed after 26 min on run 4041 job 4; this PR changes two Python lines in `scripts/lilith/dojo/baseline.py` and no Rust file. The same job passed on the previous main head (`4d45b65c`, PR #559). Local evidence: `uv run --no-project --with pytest python -m pytest dojo/tests program/tests exam -q` → 729 passed, 4 skipped. Reason for not waiting on a rerun: the run-4 acceptance resume is blocked on this fix and the pod is stopped to avoid idle spend (operator instruction 2026-10-06).

toasterson merged commit fdce1dd887 into main 2026-10-06 20:12:18 +00:00

toasterson referenced this pull request from a commit 2026-10-06 20:12:19 +00:00

Merge pull request 'fix(lilith): exam adapter args have no enable_thinking; read it tolerantly' (#563) from fix/lilith-exam-enable-thinking into main

toasterson referenced this pull request 2026-10-06 22:20:23 +00:00

docs(lilith): RESULT for program r4 (siblings in context) — NOT CERTIFIED #568

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

follow-up

Documented operational follow-up

No labels

follow-up

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

toasterson/akh-medu!563

No description provided.